Image improvements #391
Merged
Image improvements #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all PNGs are gone, as several don't seem to have corresponding drawio files. We might have to recreate these later. Some other changes were made, like replacing a table image with an actual markdown table.
rafbiels
requested changes
Apr 23, 2025
DuncanMcBain
commented
Apr 28, 2025
There was a problem hiding this comment.
So I've just seen that at least some of the SVG images contain PNG data embedded in them and now I'm very upset. I think this will have to be fixed later, possibly doing it a slide at a time, and possibly when we move the content to markdown files instead of HTML (i.e. only one index.html dynamically loading the content).
rafbiels
reviewed
Apr 29, 2025
it was accidentally a code block
rafbiels
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the Codeplay logo and SVG'd a bunch of the PNGs that were shipping previously.